Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cheri_compartment: Warn if return type is void or return value is unused #80

Merged

Conversation

v01dXYZ
Copy link

@v01dXYZ v01dXYZ commented Dec 17, 2024

Reapply #47

Changes since that version:

  • Squashed history.
  • Removed early return that caused link errors. (fix by early returning for Decl instead of DeclChunk)
  • Disable. warning by default while CheriotRTOS transitions.

Superseed #79

Copy link
Collaborator

@resistor resistor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash history.

clang/lib/Sema/SemaDeclAttr.cpp Outdated Show resolved Hide resolved
@v01dXYZ v01dXYZ force-pushed the warn-if-void-return-declchunk-fix branch 2 times, most recently from 80f786f to 6df8f9f Compare December 18, 2024 11:07
Copy link
Collaborator

@resistor resistor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash history and verify a CheriotRTOS build before landing.

@v01dXYZ v01dXYZ force-pushed the warn-if-void-return-declchunk-fix branch from 6df8f9f to b8072f8 Compare December 19, 2024 09:38
@v01dXYZ
Copy link
Author

v01dXYZ commented Dec 19, 2024

I made an error. This time, I tested with rtos-tests and the build completes.

@resistor resistor merged commit 025c5d4 into CHERIoT-Platform:cheriot Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants