Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MQTT support for publishing retained messages #53

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

PhilDay-CT
Copy link
Contributor

Adds the option to make a published message retained by the broker.

Also sets the bounds on the topic and message passed to the publishCallback so that callback can't access any other parts of the buffer.

Copy link
Member

@nwf nwf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

include/mqtt.h Show resolved Hide resolved
@hlef
Copy link
Collaborator

hlef commented Nov 27, 2024

Sorry for coming late! Looks good to me, it would just be great if we could document the new retain parameter in the API documentation before merging.

include/mqtt.h Outdated Show resolved Hide resolved
@hlef
Copy link
Collaborator

hlef commented Nov 29, 2024

Looks good to me! @davidchisnall merging since Wes ACK-ed too.

@hlef hlef merged commit 7ab4836 into CHERIoT-Platform:main Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants