Successfully translated src/start.js to typescript. Fixed Issue #82 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the task of translating src/start.js to typescript. This PR is in response to issue # 52. The main process involved in this translation was ensuring that proper types are defined for variables and that the code follows the listing requirements of typescript that were laid forth by estlint. After translating the file, the code was tested through the test cases already written with the mocha framework. In this translation I also used the 'eslint-disable-next-line' feature which allowed me to use existing modules (not translated to typescript yet) in my translation of the file.