Refactor src/topics/unread.js

[Tasnim1147]

Refactored the getTids function to reduce function nesting to no more than four levels deep.

Changes Made:

Improved readability by implementing the areTagsAllowed and shouldIncludeTopic functions. The areTagsAllowed function now uses a for loop instead of .every(), and the shouldIncludeTopic function uses conditionals and areTagsAllowed function to reduce nesting level.

[coveralls]

Pull Request Test Coverage Report for Build 10628550285

Details

• 6 of 12 (50.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.02%) to 82.655%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/topics/unread.js	6	12	50.0%

Totals
Change from base Build 10550029021:	-0.02%
Covered Lines:	22328
Relevant Lines:	25592

---

💛 - Coveralls

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Tasnim1147]

The new issue by SonarCloud suggested using optional chaining, but the nodeBB uses [email protected], which does not fully support optional chaining.

Setup:

• Node.js: v20.16.0
• npm: 10.8.1
• ESLint: 7.32.0
• Babel Parser: @babel/[email protected]

For more details, see this Stack Overflow post discussing optional chaining support in ESLint.

[Tasnim1147]

Addresses #14