Refactoring code in src/meta/config.js

src/meta/configs.js

@@ -15,44 +15,74 @@
 
 Meta.config = {};
 
+
 // called after data is loaded from db
 function deserialize(config) {
 	const deserialized = {};
+
 	Object.keys(config).forEach((key) => {
 		const defaultType = typeof defaults[key];
 		const type = typeof config[key];
 		const number = parseFloat(config[key]);
 
-		if (defaultType === 'string' && type === 'number') {
-			deserialized[key] = String(config[key]);
-		} else if (defaultType === 'number' && type === 'string') {
-			if (!isNaN(number) && isFinite(config[key])) {
-				deserialized[key] = number;
-			} else {
-				deserialized[key] = defaults[key];
-			}
-		} else if (config[key] === 'true') {
-			deserialized[key] = true;
-		} else if (config[key] === 'false') {
-			deserialized[key] = false;
-		} else if (config[key] === null) {
-			deserialized[key] = defaults[key];
-		} else if (defaultType === 'undefined' && !isNaN(number) && isFinite(config[key])) {
-			deserialized[key] = number;
-		} else if (Array.isArray(defaults[key]) && !Array.isArray(config[key])) {
-			try {
-				deserialized[key] = JSON.parse(config[key] || '[]');
-			} catch (err) {
-				winston.error(err.stack);
-				deserialized[key] = defaults[key];
-			}
-		} else {
-			deserialized[key] = config[key];
-		}
+		deserialized[key] = handleTypeConversion(defaultType, type, config[key], number, key);
 	});
+
 	return deserialized;
 }
 
+// got this code from ChatGPT
+function handleTypeConversion(defaultType, type, value, number, key) {
+	if (defaultType === 'string' && type === 'number') {
+		return String(value);
+	}
+
+	if (defaultType === 'number' && type === 'string') {
+		return handleNumberConversion(number, value, key);
+	}
+
+	if (value === 'true') {
+		return true;
+	}
+
+	if (value === 'false') {
+		return false;
+	}
+
+	if (value === null) {
+		return defaults[key];
+	}
+
+	if (defaultType === 'undefined' && !isNaN(number) && isFinite(value)) {
+		return number;
+	}
+
+	if (Array.isArray(defaults[key]) && !Array.isArray(value)) {
+		return handleArrayConversion(value, key);
+	}
+
+	return value;
+}
+
+console.log("Reem")
+
+function handleNumberConversion(number, value, key) {
+	if (!isNaN(number) && isFinite(value)) {
+		return number;
+	}
+	return defaults[key];
+}
+
+function handleArrayConversion(value, key) {
+	try {
+		return JSON.parse(value || '[]');
+	} catch (err) {
+		winston.error(err.stack);
+		return defaults[key];
+	}
+}
+
+
 // called before data is saved to db
 function serialize(config) {
 	const serialized = {};

src/posts/create.js

@@ -71,6 +71,7 @@ module.exports = function (Posts) {
 		return result.post;
 	};
 
+
 	async function addReplyTo(postData, timestamp) {
 		if (!postData.toPid) {
 			return;

src/user/create.js

@@ -122,6 +122,8 @@
 		return userData.uid;
 	}
 
+	console.log("Reem")
+
 	async function storePassword(uid, password) {
 		if (!password) {
 			return;

test/meta.js

@@ -11,6 +11,7 @@
 const Groups = require('../src/groups');
 const request = require('../src/request');
 
+
 describe('meta', () => {
 	let fooUid;
 	let bazUid;
@@ -570,7 +571,10 @@
 			});
 			assert.equal(response.headers['access-control-allow-origin'], 'mydomain.com');
 			meta.config['access-control-allow-origin-regex'] = oldValue;
 		});
+
+
+
 	});
 
 	it('should log targets', (done) => {