Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring code in src/notification.js of NodeBB #86

Open
wants to merge 3 commits into
base: f24
Choose a base branch
from

Conversation

tatougueye
Copy link

@tatougueye tatougueye commented Sep 4, 2024

Refactored the notification system to improve code readability and maintainability by breaking down large functions into smaller, reusable ones. Specifically refactored 2 functions: 'notifications.Each' and 'differentiators.forEach'. Removed redundant logic and streamlined the process for sending notifications and emails. All functionality has been tested through existing unit tests and manual verification. resolves #11

@coveralls
Copy link

coveralls commented Sep 4, 2024

Pull Request Test Coverage Report for Build 10703751020

Details

  • 27 of 33 (81.82%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 82.662%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/notifications.js 27 33 81.82%
Files with Coverage Reduction New Missed Lines %
src/notifications.js 1 79.04%
Totals Coverage Status
Change from base Build 10550029021: -0.009%
Covered Lines: 22331
Relevant Lines: 25594

💛 - Coveralls

Copy link

sonarqubecloud bot commented Sep 4, 2024

@tatougueye tatougueye changed the title Refactoring code in Notification.js of NodeBB Refactoring code in src/notification.js of NodeBB Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring code in src/notification.js
2 participants