Integrating JShint into our Workflow #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request finalizes the integration of JSHint into our development workflow. The integration includes adjustments to our package.json, the addition of JSHint configuration files, and updates to our GitHub Actions to incorporate JSHint checks. This ensures that our code adheres to our specified coding standards automatically before merges.
Adding JSHint to scripts in package.json:
Modified the scripts section to include a JSHint run command, allowing developers to execute lint checks manually.
Added and populated .jshintignore & .jshintrc:
.jshintignore: Specified files and directories that JSHint should ignore during its run.
.jshintrc: Defined a set of linting rules tailored to our project's coding standards to ensure consistency.
Trying to Integrate JSHint into our GitHub workflow:
Updated our GitHub Actions configuration to try and run JSHint checks on pushes and pull requests to the f24 branch. This is crucial for catching issues early and ensuring that only code that meets our quality standards is merged. This does not function correctly in this PR even though we did add the jshint.yaml, but we fixed it in Fixing the jshint.yaml to Run as Part of Workflows #48.