Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Integrating JShint into our Workflow" #47

Closed
wants to merge 1 commit into from
Closed

Revert "Integrating JShint into our Workflow" #47

wants to merge 1 commit into from

Conversation

khalifat3
Copy link
Collaborator

Reverts #46

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11589892559

Details

  • 30 of 33 (90.91%) changed or added relevant lines in 22 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 82.694%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/meta/configs.js 0 1 0.0%
src/socket.io/categories.js 0 1 0.0%
src/socket.io/modules.js 0 1 0.0%
Totals Coverage Status
Change from base Build 11589683083: 0.005%
Covered Lines: 22352
Relevant Lines: 25612
💛 - Coveralls

@Abdallah-Abdaljalil
Copy link
Collaborator

Abdallah-Abdaljalil commented Oct 30, 2024 •
edited
Loading

We made a mistake and we wanted to try and revert a merge which is why we made the PR, however, it seemed to work out, which is why we decided to close this without merging. The situation is explained a bit more in #46.

@Abdallah-Abdaljalil Abdallah-Abdaljalil mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khalifat3 @coveralls @Abdallah-Abdaljalil