Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifusfront #34

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Notifusfront #34

merged 3 commits into from
Sep 26, 2024

Conversation

khalifat3
Copy link
Collaborator

@khalifat3 khalifat3 commented Sep 26, 2024

This pull request implements a frontend notification system for when a user successfully creates a new topic in the NodeBB forum. The main changes are focused on enhancing user experience by providing instant feedback via browser notifications.

Key Changes:

  • Added an event listener to capture the composer.topics.post action when a user posts a new topic.
  • Integrated the alert system (alerts.alert) to display a browser notification that includes the username of the user who created the post and the name of the topic.
  • Adjusted the event listener to ensure that notifications only trigger on topic creation, avoiding duplicates during page reloads.
  • Resolved issues with redundant notifications being displayed more than once.
  • Included basic error handling for cases where the username cannot be fetched.

These changes are intended to improve user interaction by notifying users immediately after they successfully create a new topic, providing real-time confirmation of their actions.

2nd push - Resolving lint test which was passing locally but failed on GitHub the first time because of a missing line at the end of the file.

Resolves #14

@khalifat3 khalifat3 added good first issue Good for newcomers frontEnd Issues with frontend backEnd Issues with backend labels Sep 26, 2024
@khalifat3 khalifat3 added this to the Sprint 1, week 2 milestone Sep 26, 2024
@khalifat3 khalifat3 self-assigned this Sep 26, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11054420223

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.674%

Totals Coverage Status
Change from base Build 10945554816: 0.0%
Covered Lines: 22333
Relevant Lines: 25594

💛 - Coveralls

Copy link
Collaborator

@rsharaf-dev rsharaf-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, looks fine, you should merge it to main.

@Abdallah-Abdaljalil Abdallah-Abdaljalil merged commit dccb5e8 into f24 Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backEnd Issues with backend frontEnd Issues with frontend good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Related tags notifications (front end)
4 participants