forked from CMU-17313Q/cmu-17313q-f24-nodebb-f24-NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linking the Bug Report Form with the Bug Log page through controllers (User Story 2) #42
Draft
aattiyah
wants to merge
18
commits into
f24
Choose a base branch
from
linking-database-with-bug-log
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aattiyah
added
bug
Something isn't working
frontend
main code is written in frontend
backend
main code is written in backend
High effort
Features that need high effort to implement
Incomplete
This feature is incomplete
labels
Oct 19, 2024
aattiyah
changed the title
Linking the Bug Report Form with the Bug Log page through controllers
Linking the Bug Report Form with the Bug Log page through controllers (User Story 2)
Oct 19, 2024
Pull Request Test Coverage Report for Build 11420828356Details
💛 - Coveralls |
lhitmi
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code looks clear!
akobaidan
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code looks good and effective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
main code is written in backend
bug
Something isn't working
frontend
main code is written in frontend
High effort
Features that need high effort to implement
Incomplete
This feature is incomplete
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is supposed to be the attempt made at linking the Bug Report Form and the Bug Log page by using controller logic and API endpoints, in which reports submitted on the form would show up on the Bug Log page under the dashboards section in the Admin page.
Originally, the logic was meant to go through a database, in which reports would be stored. However, due to code complexities, we replanned to link the two pages and send data through controllers.
In order to fetch the data, we created a GET request API route in src/routes/admin.js. This API is successfully working as it is able to fetch the information submitted to the forms. Along with this, we created a POST request API in the same file; however, upon calling this API, we have encountered a 403 forbidden error, which significantly hindered our progress as we couldn't figure out how to bypass it.
The view template for the form (src/views/bug-report-form.tpl) was also changed as we added an event listener which helped us fetch the data.
The following group members have contributed to writing code in this pull request:
This pull request resolves issues #33 and #17.