Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking the Bug Report Form with the Bug Log page through controllers (User Story 2) #42

Draft
wants to merge 18 commits into
base: f24
Choose a base branch
from

Conversation

aattiyah
Copy link

@aattiyah aattiyah commented Oct 19, 2024

This pull request is supposed to be the attempt made at linking the Bug Report Form and the Bug Log page by using controller logic and API endpoints, in which reports submitted on the form would show up on the Bug Log page under the dashboards section in the Admin page.

Originally, the logic was meant to go through a database, in which reports would be stored. However, due to code complexities, we replanned to link the two pages and send data through controllers.

In order to fetch the data, we created a GET request API route in src/routes/admin.js. This API is successfully working as it is able to fetch the information submitted to the forms. Along with this, we created a POST request API in the same file; however, upon calling this API, we have encountered a 403 forbidden error, which significantly hindered our progress as we couldn't figure out how to bypass it.

The view template for the form (src/views/bug-report-form.tpl) was also changed as we added an event listener which helped us fetch the data.

The following group members have contributed to writing code in this pull request:

  • Aisha Al Attiyah
  • Ahmad Al Obaidan
  • Latifa Al Hitmi

This pull request resolves issues #33 and #17.

@aattiyah aattiyah added bug Something isn't working frontend main code is written in frontend backend main code is written in backend High effort Features that need high effort to implement Incomplete This feature is incomplete labels Oct 19, 2024
@aattiyah aattiyah added this to the Sprint 2 milestone Oct 19, 2024
@aattiyah aattiyah requested review from akobaidan and lhitmi October 19, 2024 20:55
@aattiyah aattiyah marked this pull request as draft October 19, 2024 20:56
@aattiyah aattiyah changed the title Linking the Bug Report Form with the Bug Log page through controllers Linking the Bug Report Form with the Bug Log page through controllers (User Story 2) Oct 19, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11420828356

Details

  • 9 of 25 (36.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 82.633%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/controllers/admin/dashboard.js 7 23 30.43%
Files with Coverage Reduction New Missed Lines %
src/meta/templates.js 3 84.54%
Totals Coverage Status
Change from base Build 11057241668: -0.05%
Covered Lines: 22358
Relevant Lines: 25639

💛 - Coveralls

@mohamed-elzeni mohamed-elzeni marked this pull request as ready for review October 20, 2024 17:03
@mohamed-elzeni mohamed-elzeni marked this pull request as draft October 20, 2024 17:03
Copy link

@lhitmi lhitmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks clear!

Copy link

@akobaidan akobaidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks good and effective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend main code is written in backend bug Something isn't working frontend main code is written in frontend High effort Features that need high effort to implement Incomplete This feature is incomplete
Projects
None yet
4 participants