Improve Reading Time Display on post views #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssaigh
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
It looks good for me
-Adding a placeholder for estimated reading time makes sense as it allows you to target the right post
-"span id="reading-time-{posts.pid}" class="text-muted me-3"
-Adding ID to post content makes it to locate the content
-Overall mechanism for displaying the time from the function makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request done enhancements to the UI by displaying the Estimated Reading Time (ERT) for posts immediately upon the data load. Feature aims to improve user engagement, providing quick insights into post length without need for a page reload.
Changes include:
Changed 2 files: src/views/post-queue.tpl and node_modules/nodebb-theme-harmony/templates/partials/topic/post.tpl.
Update targets better user experience by making the post interactions more efficient as well as informative.
Resolved Task #4