Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS qt5 arm64 build #485

Merged
merged 7 commits into from
Jun 13, 2024
Merged

MacOS qt5 arm64 build #485

merged 7 commits into from
Jun 13, 2024

Conversation

hannesa2
Copy link
Collaborator

Build on a arm64 MacOS

@bunty95
Copy link
Collaborator

bunty95 commented Jun 10, 2024

@hannesa2 below changes will fix the issues you are having on arm64 with MacOS.
Replace relevant sections (line 14 and 38) or check my build.sh

build.sh
if [[ $(uname -m) == 'arm64' ]]; then
Qt5_DIR="/opt/homebrew/opt/qt@5"

cmake -G Ninja
-DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}
-DCMAKE_PREFIX_PATH=${Qt5_DIR}/lib/cmake \

Let me know if there are any issues.

hannesa2 added a commit to hannesa2/dlt-viewer that referenced this pull request Jun 11, 2024
hannesa2 added a commit that referenced this pull request Jun 11, 2024
@hannesa2 hannesa2 force-pushed the MacOS-qt5-arm64-cmake branch from f3cd1d3 to 4eb5e1a Compare June 11, 2024 04:48
hannesa2 added a commit that referenced this pull request Jun 11, 2024
@hannesa2 hannesa2 force-pushed the MacOS-qt5-arm64-cmake branch from 4eb5e1a to 9a9933b Compare June 11, 2024 04:51
hannesa2 added a commit that referenced this pull request Jun 11, 2024
@hannesa2 hannesa2 force-pushed the MacOS-qt5-arm64-cmake branch from 9a9933b to 0a8cf8e Compare June 11, 2024 04:56
@hannesa2 hannesa2 force-pushed the MacOS-qt5-arm64-cmake branch from 0a8cf8e to f33946e Compare June 11, 2024 04:59
@hannesa2
Copy link
Collaborator Author

@bunty95 Sorry, it's not working f33946e

Please can you can make a pull request on top of this one ? This would be the most efficient way.

@bunty95
Copy link
Collaborator

bunty95 commented Jun 13, 2024

@hannesa2 I will make a pull request using the fork you have.

bunty95 and others added 2 commits June 12, 2024 21:28
updated qt for arm64
Issue #485 - Possible solution
@hannesa2 hannesa2 changed the title MacOS qt5 arm64 cmake MacOS qt5 arm64 build Jun 13, 2024
@hannesa2 hannesa2 merged commit 1113b2e into master Jun 13, 2024
4 checks passed
@hannesa2 hannesa2 removed the WIP label Jun 13, 2024
@hannesa2 hannesa2 deleted the MacOS-qt5-arm64-cmake branch June 13, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build pipeline Build pipeline for CI macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants