Simplify handling of logging only mode in log table view #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Kopp <[email protected]>
|
@vifactor Are you able or did you already test this in an Online Logging use case? |
|
I have tried it with enabling and disabling this feature and it works, at least in the offline mode. |
|
I tried in offline too. I will check it in online a bit later |
|
online mode seem to work too: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this MR logging only mode is handled separately before any message decoding happens. Before this MR, although msg was default-assigned in one of the if-cases, it still was non-empty due to multiple decodings happening in the data-method for values of
role-variable other thanDisplayRole.