Fix compilation issues #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without them we had incomplete types.
This is needed, because dlt_common.c includes `<QtGlobal>` which includes implicitly `<qtypes.h>` which contains ``` static_assert(sizeof(ptrdiff_t) == sizeof(size_t), "Weird ptrdiff_t and size_t definitions"); ... ``` But `static_assert` in C is available only from c11 standard. Though this is working with clang, but not with gcc compiler, so we set the standard explicitly to c11.
|
thanks for fixing, Ubuntu build was just bitten by this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1: Add missing includes
Why:
Without the missing includes, we had incomplete types.
What:
Added the necessary includes to resolve the incomplete types issue.
Commit 2: Set C standard to c11
Why:
dlt_common.cincludes<QtGlobal>which implicitly includes<qtypes.h>, which contains astatic_assertthat requires the C11 standard. This was causing issues with the GCC compiler, which does not supportstatic_assertin earlier C standards.What:
Explicitly set the C standard to C11 to ensure compatibility with the
static_assertusage in the code.