improve mingw compatibility and free the console in additional places #588
+36
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudomgamal
changed the title
|
@sudomgamal Please fix the merge conflict. |
|
Please also add a signed off statement to the commit message. |
…places - the flags added using add_defnintions will be appended to all compiler tools including the resource compiler (rc) which breaks the build use CMAKE_CXX_FLAGS instead. - close the windows consolewhen the user opens the dlt-viewer using a file doubleclick in the windows explorer Signed-off-by: sudomgamal <[email protected]>
Signed-off-by: sudomgamal <[email protected]>
|
done |
|
@vifactor Please review the change, if possible. |
vifactor
requested changes
Jan 7, 2025
qdlt/qdltoptmanager.cpp
Outdated
|
|
||
| if(closeConsole) | ||
| { | ||
| #if (WIN32 || WIN64) |
There was a problem hiding this comment.
I see a code duplicate, since exactly the same piece of code is at the end of this function. Could you please wrap this in a function and use it in two places?
Signed-off-by: sudomgamal <[email protected]>
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including the resource compiler (rc) which breaks the build. Use CMAKE_CXX_FLAGS instead.