Move some vars and code to SearchForm from MainWindow

src/mainwindow.cpp

@@ -56,9 +56,7 @@
  * Must be a "C" include to interpret the imports correctly
  * for MSVC compilers.
  **/
-#include "dlt_common.h"
 extern "C" {
-
     #include "dlt_user.h"
 }
 
@@ -200,8 +198,6 @@ MainWindow::MainWindow(QWidget *parent) :
     ui->actionProject->setChecked(ui->dockWidgetContents->isVisible());
     ui->actionSearch_Results->setChecked(ui->dockWidgetSearchIndex->isVisible());
 
-    newCompleter = new QCompleter(&m_CompleterModel,this);
-
     /* what for do we need the next 2 lines ? */
     draw_timer.setSingleShot (true);
     connect(&draw_timer, SIGNAL(timeout()), this, SLOT(draw_timeout()));
@@ -278,7 +274,6 @@ MainWindow::~MainWindow()
     delete dltIndexer;
     delete m_shortcut_searchnext;
     delete m_shortcut_searchprev;
-    delete newCompleter;
     delete sortProxyModel;
 }
 
@@ -2384,21 +2379,15 @@ void MainWindow::on_action_menuFile_Quit_triggered()
 
 void MainWindow::on_actionFindNext()
 {
-    //qDebug() << "on_actionFindNext" << __LINE__;
-    if(!searchInput->input()->text().isEmpty() && !list.contains(searchInput->input()->text()))
-       {
-           list.append(searchInput->input()->text());
-       }
-    QString title = "Search Results";
+    searchInput->updateHistory();
 
+    QString title = "Search Results";
     if ( 0 < m_searchtableModel->get_SearchResultListSize())
     {
-        title = QString("Search Results: %L1").arg(m_searchtableModel->get_SearchResultListSize());
+        title += QStringLiteral(": %L1").arg(m_searchtableModel->get_SearchResultListSize());
     }
     ui->dockWidgetSearchIndex->setWindowTitle(title);
     ui->dockWidgetSearchIndex->show();
-    m_CompleterModel.setStringList(list);
-    searchInput->input()->setCompleter(newCompleter);
 }
 
 void MainWindow::on_action_menuProject_New_triggered()
@@ -4488,6 +4477,7 @@ void MainWindow::controlMessage_ReceiveControlMessage(EcuItem *ecuitem, const QD
             versionString(msg);
             autoloadPluginsVersionEcus.append(msg.getEcuid());
         }
+        break;
     }
     case DLT_SERVICE_ID_GET_LOG_INFO:
     {
@@ -7871,8 +7861,6 @@ void MainWindow::on_actionJump_To_triggered()
     }
 
     jump_to_line(dlg.getIndex());
-
-
 }
 
 
@@ -8235,18 +8223,10 @@ void MainWindow::on_actionDefault_Filter_Reload_triggered()
     /* load the default filter list */
     defaultFilter.load(dir.absolutePath());
 
-    QStringList completerList;
-
-    /* default filter list update combobox */
-    QDltFilterList *filterList;
-    foreach(filterList,defaultFilter.defaultFilterList){
+    // default filter list update combobox
+    for (const auto *filterList : defaultFilter.defaultFilterList) {
         ui->comboBoxFilterSelection->addItem(filterList->getFilename());
-        completerList << filterList->getFilename();
     }
-    //QCompleter *completer = new QCompleter(completerList, this);
-    //completer->setFilterMode(Qt::MatchContains);
-    //completer->setCaseSensitivity(Qt::CaseInsensitive);
-    //ui->comboBoxFilterSelection->setCompleter(completer);
 }
 
 void MainWindow::on_actionDefault_Filter_Create_Index_triggered()

src/mainwindow.h

@@ -28,8 +28,6 @@
 #include <QColor>
 #include <QComboBox>
 #include <QProgressBar>
-#include <QCompleter>
-#include <QStringListModel>
 
 #include "tablemodel.h"
 #include "settingsdialog.h"
@@ -43,14 +41,6 @@
 #include "ui_mainwindow.h"
 #include "searchform.h"
 
-
-/**
- * When ecu items buffer size exceeds this while using
- * serial connection, it will be considered corrupted.
- **/
-
-#define DLT_BUFFER_CORRUPT_TRESHOLD 4* 1024
-
 /**
  * @brief Namespace to contain the toolbar positions.
  * You should always remember to update these enums if you
@@ -116,7 +106,6 @@ class MainWindow : public QMainWindow
 
 private:
     Ui::MainWindow *ui;
-    QCompleter *newCompleter;
     /* Timer for connecting to ECUs */
     QTimer timer;
 
@@ -374,8 +363,6 @@ class MainWindow : public QMainWindow
     /* default filters */
     void resetDefaultFilter();
 
-    QStringListModel m_CompleterModel;
-
     /* Get path from explorerView model index */
     QString getPathFromExplorerViewIndexModel(const QModelIndex &proxyIndex);
 
@@ -626,7 +613,6 @@ public slots:
     QDltDefaultFilter defaultFilter;
 
     QStringList openFileNames;
-    QStringList list;
 
     /* store startLoggingDateTime when logging first data */
     QDateTime startLoggingDateTime;

src/searchform.cpp

@@ -2,6 +2,7 @@
 #include "ui_searchform.h"
 
 #include <QLineEdit>
+#include <QCompleter>
 
 SearchForm::SearchForm(QWidget *parent)
     : QWidget(parent)
@@ -12,6 +13,9 @@ SearchForm::SearchForm(QWidget *parent)
     ui->comboBox->setLineEdit(new QLineEdit);
     ui->comboBox->setInsertPolicy(QComboBox::InsertAtTop);
 
+    m_completer = new QCompleter(&m_historyModel, this);
+    input()->setCompleter(m_completer);
+
     connect (ui->abortButton, &QPushButton::clicked, this, &SearchForm::abortSearch);
 }
 
@@ -46,3 +50,11 @@ void SearchForm::resetProgress()
 {
     setProgress(0);
 }
+
+void SearchForm::updateHistory() {
+    if (auto list = m_historyModel.stringList();
+        !input()->text().isEmpty() && !list.contains(input()->text())) {
+        list.append(input()->text());
+        m_historyModel.setStringList(std::move(list));
+    }
+}

src/searchform.h

@@ -2,12 +2,14 @@
 #define SEARCHFORM_H
 
 #include <QWidget>
+#include <QStringListModel>
 
 namespace Ui {
 class SearchForm;
 }
 
 class QLineEdit;
+class QCompleter;
 
 class SearchForm : public QWidget
 {
@@ -27,12 +29,16 @@ class SearchForm : public QWidget
     void setState(State state);
     void setProgress(int val);
     void resetProgress();
+    void updateHistory();
 
 signals:
     void abortSearch();
 
 private:
     Ui::SearchForm *ui;
+
+    QCompleter *m_completer{nullptr};
+    QStringListModel m_historyModel;
 };
 
 #endif // SEARCHFORM_H