Minor plugins refactoring #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Kopp <[email protected]>
Signed-off-by: Viktor Kopp <[email protected]>
Signed-off-by: Viktor Kopp <[email protected]>
Signed-off-by: Viktor Kopp <[email protected]>
Signed-off-by: Viktor Kopp <[email protected]>
Signed-off-by: Viktor Kopp <[email protected]>
vifactor
commented
Jan 7, 2025
| } | ||
|
|
||
|
|
||
| void QDltPluginManager::decodeMsg(QDltMsg &msg, int triggeredByUser) |
There was a problem hiding this comment.
this is probably the only function which is kinda used in multithreaded context, it is hence the only one that has to be protected by the mutex.
vifactor
commented
Jan 7, 2025
| @@ -71,7 +71,7 @@ class QDLT_EXPORT QDltPlugin | |||
| bool isCommand(); | |||
|
|
|||
| // generic plugin interfaces | |||
| QString name(); | |||
| QString name() const; | |||
There was a problem hiding this comment.
many of the methods here should actually be const, but I do not change that because I do not know what promise we have to hold for plugins implementers
alexmucde
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly removal unnecessary heap allocations (use stack instead), redundant code removal, use of algos instead of raw loops