-
Notifications
You must be signed in to change notification settings - Fork 172
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: Pierre Pierre Blais <[email protected]>
- Loading branch information
Showing
5 changed files
with
66 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
# Introduction to VSS Contribution Process | ||
|
||
The COVESA VSS project has public two GitHub repositories | ||
The COVESA VSS project has two public GitHub repositories: | ||
|
||
- [Vehicle Signal Specification (VSS)](https://github.com/COVESA/vehicle_signal_specification), containing signal specifications and documentation. | ||
- [VSS Tools](https://github.com/COVESA/vss-tools), containing tools for validating and transforming VSS specifications. | ||
|
@@ -15,13 +15,13 @@ There are two main methods to propose changes or extensions to VSS: | |
|
||
All contributions must follow the [COVESA contribution guidelines](https://www.covesa.global/contribute). | ||
|
||
The VSS project has regular meetings at Tuesdays 16.00 CET (see [COVESA VSS Wiki](https://wiki.covesa.global/display/WIK4/VSS+-+Vehicle+Signal+Specification)). | ||
In the meetings Pull Requests and Issues are discussed, and if a Pull Request is acceptable the meeting will decide that it shall be merged. | ||
The VSS project has regular meetings on Tuesdays at 16.00 CET and CEST in the summer (see [COVESA VSS Wiki](https://wiki.covesa.global/display/WIK4/VSS+-+Vehicle+Signal+Specification)). | ||
In the meetings Pull Requests (PRs) and Issues are discussed and, if a Pull Request is accepted, a decision to merge the PR will be made. | ||
Everyone interested is welcome to join the meetings. | ||
|
||
## Creating a Pull Request towards VSS | ||
|
||
This is the typical workflow for preparing a pull request. A Github account is required. | ||
This is the typical workflow for preparing a pull request. A GitHub account is required. | ||
|
||
1. Create a personal or company fork of the [VSS repository](https://github.com/COVESA/vehicle_signal_specification) | ||
and/or [VSS-Tools repository](https://github.com/COVESA/vss-tools). | ||
|
@@ -31,9 +31,9 @@ This is the typical workflow for preparing a pull request. A Github account is r | |
5. Introduce the wanted changes or extensions in your local development environment, see guidelines below. | ||
If you want change/extend VSS-signals, it is the *.vspec files in the [spec](https://github.com/COVESA/vehicle_signal_specification/tree/master/spec) folder that | ||
needs to be updated. | ||
6. Verify that your changes fulfil VSS Continuous Integration requirements, see [BUILD.md](BUILD.md) for some guidance. | ||
6. Verify that your changes fulfill VSS Continuous Integration requirements, see [BUILD.md](BUILD.md) for some guidance. | ||
7. Create a commit and upload to your own fork. | ||
8. In the GitHub UI create a Pull Request from your fork to the master branch of [the VSS repository](https://github.com/COVESA/vehicle_signal_specification). | ||
8. In the GitHub UI, create a Pull Request from your fork to the master branch of [the VSS repository](https://github.com/COVESA/vehicle_signal_specification). | ||
9. Validate that automatic build checks for the PR succeed. | ||
|
||
## Handling of the created Pull Request | ||
|
@@ -43,9 +43,9 @@ This is the typical workflow for preparing a pull request. A Github account is r | |
It is preferable if the PR creator can participate and give a quick introduction on the rationale for the change. | ||
3. Unless trivial, PRs shall typically be open for at least a week before merging is considered, to give time for comments. | ||
4. If needed, the PR creator needs to refactor the PR to address received comments and remarks. | ||
4. After a while, if all comments and concerns have been sorted out and no-one objects merging the PR the meeting will decide to merge the PR. | ||
4. After a while, if all comments and concerns have been sorted out and no-one objects merging, a decision will be made in the meeting to merge the PR. | ||
It is not guaranteed that all PRs will be accepted. The VSS meeting may reject and close Pull Requests. | ||
5. A VSS maintainer will perform the merge. | ||
5. A VSS maintainer will perform the final merge. | ||
|
||
## Guidelines and Recommendations | ||
|
||
|
@@ -55,7 +55,7 @@ This section includes general guidelines and recommendations for anyone interest | |
|
||
COVESA has defined [contribution guidelines](https://www.covesa.global/contribute). | ||
|
||
Every contribution must carry the following sign-off line with your real name and email address: | ||
Every contribution (commit) must carry the following sign-off line with your real name and email address: | ||
|
||
`Signed-off-by: Firstname Lastname <[email protected]>` | ||
|
||
|
@@ -69,7 +69,7 @@ This currently applies to the following file types: | |
* VSS source files (`*.vspec`) | ||
* Python files (vss-tools, `*.py`) | ||
|
||
Those files shall have copyright statement of this form, inspired by the [Eclipse generic copyright header](https://www.eclipse.org/projects/handbook/#ip-copyright-headers). | ||
Those files shall have copyright statement of the following form, inspired by the [Eclipse generic copyright header](https://www.eclipse.org/projects/handbook/#ip-copyright-headers). | ||
Copyright/License-statement may also be added to other files if considered relevant. | ||
|
||
``` | ||
|
@@ -82,12 +82,12 @@ Copyright/License-statement may also be added to other files if considered relev | |
# SPDX-License-Identifier: MPL-2.0 | ||
``` | ||
Where XXXX is the year the file was originally created, no need to update or append new years or a range of years later. | ||
Where {year} is the year the file was originally created. No need to update or append new years or a range of years later. | ||
|
||
### VSS Signals shall be generic | ||
|
||
Signals added to standard VSS shall be generic, i.e. it shall be possible that other manufacturers can reuse the signal. | ||
Manufacturer-specific signals shall preferably be part of private overlays, and not part of standard VSS. | ||
Signals added to standard VSS shall be generic, i.e. it shall be possible for other manufacturers to reuse the signal. | ||
Manufacturer-specific signals shall preferably be part of private overlays and not part of standard VSS. | ||
|
||
### Logical path | ||
|
||
|
@@ -106,7 +106,7 @@ It shall be possible to interpret a signal value by reading the signal descripti | |
Describe if needed how the value shall be calculated/interpreted, | ||
for example if it is based on a standard or if it is up to the manufacturer to select algorithm/method. | ||
|
||
* Example: A signal Vehicle.Weight would be ambiguous unless you specify that it refers to e.g. gross weight or curb weight. | ||
* Example: A signal Vehicle.Weight would be ambiguous unless you specify that it refers to gross weight or curb weight. | ||
* Example: Specifying an allowed value `MODE_2` is ambiguous unless you also specify what `MODE_2` means, e.g. by referring to a standard. | ||
|
||
### No duplicates | ||
|
@@ -117,19 +117,19 @@ VSS generally avoids to have duplicates in the signal tree, i.e. signals with sa | |
|
||
Try to reuse the same style as used for existing signals. | ||
Only specify min/max-values if there is a logical reason to limit the range. | ||
Boolean signals should start with `Is*`. | ||
Boolean signals should start with `Is`, as in `IsOpen`. | ||
American English is preferred over British English. | ||
No trailing blanks. | ||
Follow the style guide in the [documentation](https://covesa.github.io/vehicle_signal_specification/rule_set/basics/#style-guide). | ||
|
||
### No scaling, SI-unit, natural datatype | ||
|
||
VSS is not concerned with how signals are transmitted, and does not consider scaling/offset typically used in transport protocols. | ||
VSS is not concerned with how signals are transmitted and does not consider scaling/offset typically used in transport protocols. | ||
VSS signals typically use the unit used by humans when talking about the value, but prefers SI-units when feasible, | ||
see [documentation](https://covesa.github.io/vehicle_signal_specification/rule_set/data_entry/data_unit_types/) for all supported units. | ||
If it is unlikely that someone is interested in decimals for this value, select a signed or unsigned integer type. | ||
Select a size which with reasonable margins can cover all vehicles. | ||
If it is likely that decimal values are needed select float or if relevant double. | ||
If it is likely that decimal values are needed, select float or, if relevant, double. | ||
|
||
### Avoid backward incompatible changes | ||
|
||
|
@@ -138,6 +138,6 @@ Merging can be delayed, as VSS may decide to wait with the change until the next | |
|
||
### Getting Support | ||
|
||
To avoid time consuming refactoring it could for bigger contributions be relevant to ask VSS if the wanted changes | ||
To avoid time consuming refactoring it could, for bigger contributions, be relevant to ask VSS if the wanted changes | ||
seems to be reasonable and likely will be accepted by VSS. Create an [issue](https://github.com/COVESA/vehicle_signal_specification/issues) | ||
and describe what you intend to do and ask for feedback. You can also create a draft pull request at an early stage and ask for comments. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters