Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnative tool refactoring. #143

Closed
wants to merge 1 commit into from
Closed

cnative tool refactoring. #143

wants to merge 1 commit into from

Conversation

UlfBj
Copy link
Contributor

@UlfBj UlfBj commented Feb 21, 2020

No description provided.

@danielwilms
Copy link
Collaborator

@UlfBj, could you briefly describe what the goal of the commit is and why it needs to be refactors. Just a couple of words, so that it's easier to review?

Maybe we should try to release it, before we split the tools, @gunnarx ?

@UlfBj
Copy link
Contributor Author

UlfBj commented Mar 25, 2020

The refactoring was mainly done in the "tree manager" code that is e. g. used in the W3C Gen2 server impl github project. Besides improving code redability, it also simplifies the coding effort for this "tree manager" to be implemented to manage other tree formats than the cnative format, such as JSON etc.

@danielwilms danielwilms requested a review from magnusfeuer March 31, 2020 17:41
@danielwilms
Copy link
Collaborator

@magnusfeuer, checks the proposal and we decide how to move forward.

@gunnarx
Copy link
Contributor

gunnarx commented Mar 31, 2020

Since I did the tree split I would prefer to wait until we merge #144 and introduce this change in the vss-tools repository instead. Otherwise I have to redo the tree split again, or some other complicated procedure that I can't think of now(probably possible with some tricks). I prefer to avoid that however.

@gunnarx
Copy link
Contributor

gunnarx commented Apr 7, 2020

More work done on #144 now, so even more reason :) @UlfBj Please recreate this PR in the https://github.com/GENIVI/vss-tools repository instead.

@danielwilms
Copy link
Collaborator

PR for tools repo recreated

@danielwilms danielwilms closed this Apr 7, 2020
@UlfBj
Copy link
Contributor Author

UlfBj commented Apr 8, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants