Fix tutorial online doc ToC heading levels #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete the directory for the Hugo Learn theme used by the online doc site before adding it back in as a subtree to simplify updates. Signed-off-by: Stephen Lawrence <[email protected]>
git-subtree-dir: tutorial/themes/learn git-subtree-split: 3202533a746f91c67de1a8fa373c0328ec1b403d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #64 by updating to the latest Hugo Learn theme version upstream.
Testing
Locally sanity tested the tutorial site to confirm it built, displayed and corrected the bug.
Dev Notes
Rather than manually integrate the updated Learn Theme code I have switched VISSR to add it as a git subtree so future upstream fixes can be more easily added by simply pulling the changes.
Git subtree was used over git submodule as the only current use of submodule is for the optional extended web client. So introducing submodule for a core component would impact how the project must be cloned. Subtree maintains the current behavior of automatically fetching the code. This may also be important for the github actions building the site.