-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Notebooks repository #266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isobelhooper
reviewed
Nov 8, 2023
isobelhooper
reviewed
Nov 8, 2023
isobelhooper
reviewed
Nov 9, 2023
isobelhooper
previously approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good for structural cleanup!
Would like to do another pass through it for spelling / punctuation / grammar, but I think it'd be reasonable to do that in a separate PR.
isobelhooper
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff is a bit inflated due to adding a new notebook and deleting an old one. Also deleted a big JSON file which was unused.
Cleaned up several examples
Fixed some dodgy maths formatting in the 3 pytket-qujax examples and my new phase estimation notebook
Phase estimation (current version)
A qujax example with dodgy formatting -> https://tket.quantinuum.com/examples/pytket-qujax-classification.html
deleted the
tket_benchmarking example
this is TOTALLY legacy as it says in the notebook itselfhttps://tket.quantinuum.com/examples/tket_benchmarking.html
Replaced the single letter variable names in
conditional_gates_example
.Imporved markdown headings
Added categories of examples (See image)