Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Notebooks repository #266

Merged
merged 55 commits into from
Nov 13, 2023
Merged

Clean up Notebooks repository #266

merged 55 commits into from
Nov 13, 2023

Conversation

CalMacCQ
Copy link
Collaborator

@CalMacCQ CalMacCQ commented Oct 26, 2023

Diff is a bit inflated due to adding a new notebook and deleting an old one. Also deleted a big JSON file which was unused.

Cleaned up several examples

Fixed some dodgy maths formatting in the 3 pytket-qujax examples and my new phase estimation notebook

Phase estimation (current version)

A qujax example with dodgy formatting -> https://tket.quantinuum.com/examples/pytket-qujax-classification.html

deleted the tket_benchmarking example this is TOTALLY legacy as it says in the notebook itself
https://tket.quantinuum.com/examples/tket_benchmarking.html

Replaced the single letter variable names in conditional_gates_example.

Imporved markdown headings

Added categories of examples (See image)

Screenshot 2023-10-30 at 11 00 11

@CalMacCQ CalMacCQ marked this pull request as draft October 26, 2023 14:18
@CalMacCQ CalMacCQ marked this pull request as ready for review October 26, 2023 17:27
@CalMacCQ CalMacCQ requested a review from isobelhooper October 26, 2023 17:27
examples/_toc.yml Outdated Show resolved Hide resolved
isobelhooper
isobelhooper previously approved these changes Nov 13, 2023
Copy link
Contributor

@isobelhooper isobelhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good for structural cleanup!

Would like to do another pass through it for spelling / punctuation / grammar, but I think it'd be reasonable to do that in a separate PR.

@CalMacCQ CalMacCQ merged commit 378bc85 into main Nov 13, 2023
5 checks passed
@CalMacCQ CalMacCQ deleted the examples/cleanup_notebooks branch November 13, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants