Improvements for the GitHub Annotations limit #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes some noise from the logs by creating a grouping that it collapsed by default.
This gets output in addition to the normal annotations. The GitHub interface only displays 10 error annotations, so this is useful when the number of violations exceeds that amount. Also outputs grouping commands so that the report can be found more easily among the other noise in the log.
smeyer198
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub only displays 10 error annotations and silently drops the rest.
https://github.com/orgs/community/discussions/26680
https://github.com/orgs/community/discussions/68471
This PR adds a warning message when more than 10 violations are found.
Additionally, the
GitHubAnnotationReporternow also outputs the normal command line report, so that the log contains all necessary information when not everything can be displayed using annotations.The action setup also uses some grouping now to de-clutter the log.
Example run with more than 10 violations:
https://github.com/Timbals/CryptoAnalysis-demo/actions/runs/8086032882