Skip to content
This repository has been archived by the owner on Sep 15, 2024. It is now read-only.

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
valkyrienyanko committed May 7, 2022
2 parents e51fa1f + 3d33a1b commit b538a06
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,6 @@ Tech tree where nodes in tree are positioned automatically via script
### [Helper Scripts](https://github.com/valkyrienyanko/GodotModules/blob/main/.github/UTILITY_SCRIPTS.md)

## Contributing
There are 3 types of problems I always run into while working on this
- Tasks are fired and forgotten (wanted behavior) but are not cancelled at proper times causing all sorts of problems
- Duplicate player id added to lobby player dictionary
- Static variables not being reset for re-use

Tasks are hard to manage, you cancel them with a cancellation token but it's hard to keep track if you cancel them twice or dispose them twice and get a disposed already exception.

With the duplicate player joining it's because their joining ID is 0 just like the host id is 0. The joining ID should be 1. Usually this is because I forgot to write or read a byte but that dosen't seem to be the case this time but I might be wrong I do not know.

Static variables are a mess, I wish I never used them to begin with.

I'm considering restarting this entire project from scratch because of how overwhelming this all is.

See [CONTRIBUTING.md](https://github.com/valkyrienyanko/GodotModules/blob/main/.github/CONTRIBUTING.md)

## Credit
Expand Down

0 comments on commit b538a06

Please sign in to comment.