Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoopIdiom] Set no_preserve_cheri_tags when possible #612

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

arichardson
Copy link
Member

This allows inlining of underaligned memcpy() calls that copy more than
capability size (which will be most of the ones created by this pass).
Previously, we weren't setting any attribute on the memcpy at all which
meant that the backends had to be conservative when inlining the memcpy.

@arichardson arichardson requested a review from jrtc27 March 18, 2022 11:30
@arichardson arichardson force-pushed the no-preserve-tags-nfc-prep branch from f307169 to 20dfcd2 Compare March 22, 2022 21:30
@arichardson arichardson force-pushed the no-preserve-tags-nfc-prep branch 3 times, most recently from 50aa1b8 to bf88828 Compare April 25, 2022 16:03
@arichardson arichardson force-pushed the no-preserve-tags-nfc-prep branch from bf88828 to eab5c92 Compare July 6, 2022 07:37
@arichardson arichardson force-pushed the no-preserve-tags-nfc-prep branch from eab5c92 to 5308fac Compare August 4, 2022 21:47
@arichardson arichardson force-pushed the no-preserve-tags-nfc-prep branch from 5308fac to 017786a Compare August 15, 2022 08:35
@arichardson arichardson force-pushed the no-preserve-tags-loopidiom branch from 7926a3e to 31340d0 Compare August 15, 2022 08:41
@arichardson
Copy link
Member Author

rebased.

@arichardson arichardson force-pushed the no-preserve-tags-nfc-prep branch from 017786a to c169ab1 Compare August 16, 2022 09:50
Base automatically changed from no-preserve-tags-nfc-prep to dev August 25, 2022 14:20
@arichardson arichardson force-pushed the no-preserve-tags-loopidiom branch from 31340d0 to 697bf7f Compare October 11, 2023 23:23
@arichardson arichardson changed the base branch from dev to upstream-llvm-merge October 11, 2023 23:24
@arichardson
Copy link
Member Author

rebased to LLVM 15

@arichardson arichardson force-pushed the no-preserve-tags-loopidiom branch from 697bf7f to 5531781 Compare November 10, 2023 17:20
@arichardson
Copy link
Member Author

ping.

@arichardson
Copy link
Member Author

ping?

@arichardson arichardson changed the base branch from upstream-llvm-merge to dev January 9, 2024 23:09
@arichardson arichardson force-pushed the no-preserve-tags-loopidiom branch from 5531781 to 997d61a Compare February 6, 2024 20:09
This allows inlining of underaligned memcpy() calls that copy more than
capability size (which will be most of the ones created by this pass).
Previously, we weren't setting any attribute on the memcpy at all which
meant that the backends had to be conservative when inlining the memcpy.
@arichardson arichardson force-pushed the no-preserve-tags-loopidiom branch from 997d61a to 9bba204 Compare February 6, 2024 21:21
@arichardson
Copy link
Member Author

@jrtc27 since this is a pretty simple change I'm going to merge this by end of week unless you have any comments.

Copy link
Member

@jrtc27 jrtc27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible

@arichardson arichardson merged commit c40085a into dev Feb 12, 2024
6 checks passed
@arichardson arichardson deleted the no-preserve-tags-loopidiom branch February 12, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants