Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia-dkms: Add LIBVA_DRIVER_NAME to profile.d #121

Merged
merged 3 commits into from
Jul 5, 2024
Merged

nvidia-dkms: Add LIBVA_DRIVER_NAME to profile.d #121

merged 3 commits into from
Jul 5, 2024

Conversation

ptr1337
Copy link
Member

@ptr1337 ptr1337 commented Jul 4, 2024

This adds the required configuration for the libva-nvidia-driver.

This makes the VAAPI support working with the direct backend.

@ptr1337 ptr1337 added the enhancement New feature or request label Jul 4, 2024
@ptr1337 ptr1337 requested review from vnepogodin and ventureoo July 4, 2024 18:35
vnepogodin
vnepogodin reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@vnepogodin vnepogodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should apply that only on non-hybrid setups

@ventureoo
Copy link
Member

we should apply that only on non-hybrid setups

post_install is overridden in the profile for hybrid graphics, so it's fine.

ventureoo
ventureoo reviewed Jul 5, 2024
View reviewed changes
Copy link
Member

@ventureoo ventureoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also specify this for 470xx profile as they support this.

@ptr1337
Copy link
Member Author

ptr1337 commented Jul 5, 2024

You should also specify this for 470xx profile as they support this.

I think they do not support the direct backend, or ?

@ventureoo
Copy link
Member

You should also specify this for 470xx profile as they support this.

I think they do not support the direct backend, or ?

Hmm, why shouldn't it supported?

ventureoo
ventureoo approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@ventureoo ventureoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnepogodin vnepogodin merged commit 9d90cd4 into master Jul 5, 2024
2 checks passed
@vnepogodin vnepogodin deleted the libva-nvidia branch July 5, 2024 10:26
@Revival8697
Copy link

Revival8697 commented Jul 28, 2024 •
edited
Loading

we should apply that only on non-hybrid setups

post_install is overridden in the profile for hybrid graphics, so it's fine.

The nvidia-vaapi.sh script show up on my Intel+Nvidia laptop so the override is not working as expected there. You might want to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnepogodin vnepogodin vnepogodin left review comments

@ventureoo ventureoo ventureoo approved these changes

Assignees

@vnepogodin vnepogodin

@ptr1337 ptr1337

@ventureoo ventureoo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ptr1337 @ventureoo @Revival8697 @vnepogodin