Mistakes fix + content update + contact infos updated #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix BDE + support for node18 + lint
Barbapapazes
requested changes
Apr 26, 2023
.env
Outdated
There was a problem hiding this comment.
The principal concerns about .env file is to store secrets so you must never commit it.
| @@ -23,7 +23,7 @@ module.exports = { | |||
| // This object corresponds to object you would export in .remarkrc file | |||
| plugins: [ | |||
| 'preset-lint-markdown-style-guide', | |||
| ['lint-no-heading-punctuation', '.,;:!?'], | |||
There was a problem hiding this comment.
This change makes it possible to end titles with punctuation without eslint issuing an error. For example:
.gitignore
Outdated
| @@ -59,7 +59,7 @@ typings/ | |||
| .yarn-integrity | |||
|
|
|||
| # dotenv environment variables file | |||
| .env | |||
| # .env # commented because it's used by the project | |||
README.md
Outdated
| @@ -35,9 +35,13 @@ When adding some images, please resize and compress them ! | |||
| **Steps** | |||
|
|
|||
| ```bash | |||
| # install dependencies | |||
| # install dependencies (execute this command with admin rights) | |||
There was a problem hiding this comment.
Not needed if your installation is correct!
README.md
Outdated
| $ npm install | ||
|
|
||
| # set environment variables (because nuxt doesn't support .env files) | ||
| $ set NODE_OPTIONS=--openssl-legacy-provider # for Windows |
There was a problem hiding this comment.
Why are you setting this env var?
|
Well, I've just committed a fix that reverts the changes made for nodeJS v18 and fixes the points raised by your review. The project uses nodeJS v16 LTS again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(If you have not already please refer to the contributing guideline as described
here))
If so, please mention them to keep the conversations linked together.
Other Information
If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.
Your PR will be reviewed by a core team member and they will work with you to get your changes merged in a timely manner. If merged your PR will automatically be added to the changelog in the next release.
Thanks for contributing to Campus INSA Centre-Val de Loire! ❤️