A0-3861: Increase MaxCodeLen for contracts. #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike1729
approved these changes
Jan 12, 2024
deuszx
approved these changes
Jan 12, 2024
DamianStraszak
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
DamianStraszak
added a commit
that referenced
this pull request
Feb 5, 2024
# Description THIS IS A RUNTIME-ONLY CHANGE. Increases the maximum code len for a contract from 128 KB to 256 KB. The reason this is safe is that the constant 72 that we have in our integrity test changed: - first 72 -> 68 (which we didn't mirror in our repo, but it's here https://github.com/paritytech/polkadot-sdk/blob/06fa111f58b0172c9f4ba7c209c8b6945787faeb/substrate/frame/contracts/src/lib.rs#L439 ) this was a result of changing gas metering - then 68 -> 32 -- this is a result of updating wasmi to v0.30 which reduces the amount of memory each instruction requires. In slack I include a message from a Pallet Contract Developer which clarifies this further. # Release note: - Increased maximum length of a contract from 128KB to 256 KB.
DamianStraszak
added a commit
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
THIS IS A RUNTIME-ONLY CHANGE.
Increases the maximum code len for a contract from 128 KB to 256 KB. The reason this is safe is that the constant 72 that we have in our integrity test changed:
Release note: