Use branch'd ink-wrapper for compatibility with aleph-node 12.1 release
#23
Conversation
deuszx
force-pushed
the
ink-wrapper-aleph-node-12.1
branch
from
c815ebb to
d8cc950
Compare
| INK_WRAPPER_VERSION=0.5.0 | ||
| CARGO_CONTRACT_VERSION=3.2.0 | ||
|
|
||
| LABEL cargo-contract="$CARGO_CONTRACT_VERSION" \ |
There was a problem hiding this comment.
You can now inspect the labels:
docker image inspect --format='{{json .Config.Labels}}' cardinal-cryptography/ink-dev-arm64
{"cargo-contract":"3.2.0","ink-wrapper":"rev-57fde9f0e31f1de610efe1879715c028849f4bc0","rust":"1.71.0"}
deuszx
force-pushed
the
ink-wrapper-aleph-node-12.1
branch
from
d8cc950 to
1c65f5f
Compare
Makefile
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| MAKEFILE_NAME := Ink development docker | |||
| DOCKER_NAME_INK_DEV := cardinal-cryptography/ink-dev | |||
| DOCKER_TAG := 1.8.0 | |||
| DOCKER_TAG := 1.8.0-r12.1-57fde9 | |||
There was a problem hiding this comment.
I'm like meh, if you can inspect the version and it's documented just bump semver?
There was a problem hiding this comment.
So 1.9.0 or 2.0.0? I am not really sure how I should go about the versioning here. The variables are:
cargo-contractink-wrapperrustaleph-nodeversion this particular image is compatible with.
Not every aleph-node change breaks the backwards compatibility, so the same ink-dev image can work with many deployments. Same with other packages here.
There was a problem hiding this comment.
If it's not backward compatible, ie ink-dev won't work with aleph-node 11.X anymore, then 2.0.0 is a must
There was a problem hiding this comment.
It's tricky b/c it will work and won't work at the same time. Since we added ink-wrapper to this image (and we hadn't initially) this adds another option to break backwards compatibility. For example, this particular image's cargoc-contract will work with 12 and 11 while its ink-wrapper won't.
I'll bump to 2.0.0 anyway.
I think it's more important to be clear about versions in the labels than correct numbering anyway.
There was a problem hiding this comment.
Did that in Bump docker tag to 2.0.0.
Makefile
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| MAKEFILE_NAME := Ink development docker | |||
| DOCKER_NAME_INK_DEV := cardinal-cryptography/ink-dev | |||
| DOCKER_TAG := 1.8.0 | |||
| DOCKER_TAG := 1.8.0-r12.1-57fde9 | |||
There was a problem hiding this comment.
If it's not backward compatible, ie ink-dev won't work with aleph-node 11.X anymore, then 2.0.0 is a must
This PR updates
ink-wrapper, installed in theink-devimage, to install the version from the feature branch where it's compatible withaleph-nodereleaser-12.1. We cannot releaseink-wrapperto crates ATM sincealeph_client's releases after version3.0.0are no longer pushed to the crates. I chose to install via--revso that later changes to the feature branch (which will definitely come) don't alter the state of the image.It also adds docker labels and bumps toolchain used to install ink-wrapper.
Here you can find changes made to the
ink-wrapper.