A0-3392 Finality checks for eth #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 4, 2023
fbielejec
reviewed
Dec 7, 2023
fbielejec
reviewed
Dec 7, 2023
relayer/src/listeners/azero.rs
Outdated
Comment on lines
371
to
381
| info!(" Decoded event data:"); | ||
| info!( | ||
| " dest_token_address: 0x{}", | ||
| hex::encode(dest_token_address) | ||
| ); | ||
| info!(" amount: {amount}"); | ||
| info!( | ||
| " dest_receiver_address: 0x{}", | ||
| hex::encode(dest_receiver_address) | ||
| ); | ||
| info!(" request_nonce: {request_nonce}\n"); |
There was a problem hiding this comment.
log it in one line, it will make sifting through logs a lot easier in the future when we need to triangulate problems
fbielejec
reviewed
Dec 7, 2023
relayer/src/listeners/azero.rs
Outdated
| if let Some(name) = &event.name { | ||
| if name.eq("CrosschainTransferRequest") { | ||
| info!("handling A0 contract event: {event:?}"); | ||
| info!("Handling A0 contract event..."); |
There was a problem hiding this comment.
either log some data or remove this log line, imo it's useless unless it carries some information to identify the request
fbielejec
reviewed
Dec 7, 2023
…ptography/membrane-bridge into A0-3392-eth-finality-checks
|
Made a slight rework of how to limit number of tasks so that more requests can be handled at the same time. |
fbielejec
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding finality checks for Ethereum side.
Comes with some fixes to encoding/decoding, enables performing funds "round trip", so bridging in both directions using relayer (tested manually).
This does not provide a proper finished implementation of crash recovery, what's to be added in later PRs:
Bounding number of tokio tasks that handle the events.(done)receive_requesttransaction to reduce number of unnecessary calls during crash recovery.