Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A0-3498: Burn returned tokens #33

Merged
merged 2 commits into from
Dec 4, 2023
Merged

A0-3498: Burn returned tokens #33

merged 2 commits into from
Dec 4, 2023

Conversation

fbielejec
Copy link
Collaborator

@fbielejec fbielejec commented Nov 28, 2023 •
edited
Loading

  • bug fix, returned tokens were accumulated in the contract instead of being burnt
  • fees mechanism impl in Solidity

@fbielejec fbielejec changed the title Burn returned tokens A0-3498: Burn returned tokens Nov 28, 2023
@krzysztofziobro
Copy link
Collaborator

Could you also add access control for mint/burn so that only bridge contract can perform these operations?

If you don't want to do it in this PR, then please create a task for it.

@fbielejec
Copy link
Collaborator Author

Could you also add access control for mint/burn so that only bridge contract can perform these operations?

If you don't want to do it in this PR, then please create a task for it.

https://cardinal-cryptography.atlassian.net/browse/A0-3579

@krzysztofziobro
Copy link
Collaborator

Could you also add a test for checking that tokens are burned correctly?

Base automatically changed from a0-3302-fees-v2 to master November 29, 2023 09:25
@fbielejec
Copy link
Collaborator Author

Could you also add a test for checking that tokens are burned correctly?

Done in an upstream PR, I will merge it here before merging all to master

@fbielejec fbielejec force-pushed the burn-returned-tokens branch 2 times, most recently from fde1bfc to 045e3af Compare November 30, 2023 12:10
krzysztofziobro
krzysztofziobro reviewed Nov 30, 2023
View reviewed changes
azero/contracts/tests/lib.rs Show resolved Hide resolved
azero/contracts/tests/lib.rs Show resolved Hide resolved
azero/contracts/tests/lib.rs Outdated Show resolved Hide resolved
eth/contracts/Membrane.sol Outdated Show resolved Hide resolved
eth/contracts/Membrane.sol Outdated Show resolved Hide resolved
eth/contracts/Membrane.sol Show resolved Hide resolved
eth/contracts/Membrane.sol Outdated Show resolved Hide resolved
eth/contracts/Membrane.sol Outdated Show resolved Hide resolved
eth/test/Membrane.js Outdated Show resolved Hide resolved
eth/test/Membrane.js Show resolved Hide resolved
@fbielejec fbielejec force-pushed the burn-returned-tokens branch 2 times, most recently from 3a39a9e to 5fba4a3 Compare December 1, 2023 14:20
@fbielejec fbielejec force-pushed the burn-returned-tokens branch from 4b1f775 to 11fa5d8 Compare December 1, 2023 14:27
@fbielejec fbielejec merged commit 06467c5 into master Dec 4, 2023
4 checks passed
@fbielejec fbielejec deleted the burn-returned-tokens branch December 4, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deuszx deuszx deuszx left review comments

@krzysztofziobro krzysztofziobro krzysztofziobro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbielejec @krzysztofziobro @deuszx