Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZK-1337: simplify directory layout & remove console logs #91

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

kroist
Copy link
Collaborator

@kroist kroist commented Jan 16, 2025

  • remove ./shielder folder, as everything is in "shielder" domain
  • add index.ts to every folder module, and list exports in it instead of exports in separate files.
  • remove console.error logs, as we throw exceptions instead.

Copy link

github-actions bot commented Jan 16, 2025

Transaction NameMainCurrentDifference (%)
NewAccountNative20003352000359+0.00120%
DepositNative18278941827930+0.00197%
WithdrawNative189816218981620.00000%

@kroist kroist changed the title ZK-1337: change folder structure & remove console logs ZK-1337: change directory layout & remove console logs Jan 17, 2025
@kroist kroist changed the title ZK-1337: change directory layout & remove console logs ZK-1337: simplify directory layout & remove console logs Jan 17, 2025
Copy link

📊 Coverage Report

📈 Total Coverage Summary

Type Covered Total Coverage
📝 Lines 142 403 ❌ 35.23%
📄 Statements 143 406 ❌ 35.22%
⚡ Functions 38 105 ❌ 36.19%
🔀 Branches 14 66 ❌ 21.21%

Coverage Legend

  • ✅ 100% Coverage
  • 🟡 80-99% Coverage
  • 🟠 50-79% Coverage
  • ❌ 0-49% Coverage

📁 File Coverage

📋 Detailed Coverage Report
File Lines Statements Functions Branches
zkOS-monorepo/ts/shielder-sdk/src/actions/deposit.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/actions/newAccount.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/actions/utils.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/actions/withdraw.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/chain/contract.ts 4.76% 4.76% 7.14% 0%
zkOS-monorepo/ts/shielder-sdk/src/chain/relayer.ts 8.57% 8.57% 14.28% 0%
zkOS-monorepo/ts/shielder-sdk/src/client.ts 0% 0% 0% 0%
zkOS-monorepo/ts/shielder-sdk/src/constants.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/events.ts 0% 0% 0% 0%
zkOS-monorepo/ts/shielder-sdk/src/state/manager.ts 0% 0% 0% 0%
zkOS-monorepo/ts/shielder-sdk/src/state/storageSchema.ts 0% 0% 0% 0%
zkOS-monorepo/ts/shielder-sdk/src/state/sync.ts 0% 0% 0% 0%
zkOS-monorepo/ts/shielder-sdk/src/utils.ts 100% 100% 100% 100%

@kroist kroist merged commit f4125cc into main Jan 17, 2025
9 checks passed
@kroist kroist deleted the ZK-1337-small-refactor branch January 17, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants