Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zk-664: rust-sdk sunset #94

Merged
merged 8 commits into from
Jan 17, 2025
Merged

Zk-664: rust-sdk sunset #94

merged 8 commits into from
Jan 17, 2025

Conversation

pmikolajczyk41
Copy link
Member

Split single crate with two features into two crates

@pmikolajczyk41 pmikolajczyk41 requested a review from kroist January 17, 2025 13:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Transaction NameMainCurrentDifference (%)
NewAccountNative20003352000383+0.00240%
DepositNative18277981827978+0.00985%
WithdrawNative18981141898066-0.00253%

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

📊 Coverage Report

📈 Total Coverage Summary

Type Covered Total Coverage
📝 Lines 142 403 ❌ 35.23%
📄 Statements 143 406 ❌ 35.22%
⚡ Functions 38 105 ❌ 36.19%
🔀 Branches 14 66 ❌ 21.21%

Coverage Legend

  • ✅ 100% Coverage
  • 🟡 80-99% Coverage
  • 🟠 50-79% Coverage
  • ❌ 0-49% Coverage

📁 File Coverage

📋 Detailed Coverage Report
File Lines Statements Functions Branches
✅ zkOS-monorepo/ts/shielder-sdk/src/actions/deposit.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/actions/newAccount.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/actions/utils.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/actions/withdraw.ts 100% 100% 100% 100%
❌ zkOS-monorepo/ts/shielder-sdk/src/chain/contract.ts 4.76% 4.76% 7.14% 0%
❌ zkOS-monorepo/ts/shielder-sdk/src/chain/relayer.ts 8.57% 8.57% 14.28% 0%
❌ zkOS-monorepo/ts/shielder-sdk/src/client.ts 0% 0% 0% 0%
✅ zkOS-monorepo/ts/shielder-sdk/src/constants.ts 100% 100% 100% 100%
❌ zkOS-monorepo/ts/shielder-sdk/src/state/events.ts 0% 0% 0% 0%
❌ zkOS-monorepo/ts/shielder-sdk/src/state/manager.ts 0% 0% 0% 0%
❌ zkOS-monorepo/ts/shielder-sdk/src/state/storageSchema.ts 0% 0% 0% 0%
❌ zkOS-monorepo/ts/shielder-sdk/src/state/sync.ts 0% 0% 0% 0%
✅ zkOS-monorepo/ts/shielder-sdk/src/utils.ts 100% 100% 100% 100%

@pmikolajczyk41
tests
e102201
@pmikolajczyk41
Merge remote-tracking branch 'origin/main' into zk-664-sdk-sunset
e7352ca 
# Conflicts:
#	Cargo.lock
#	crates/shielder-wasm/Cargo.toml
#	crates/shielder-wasm/src/secrets.rs
@pmikolajczyk41 pmikolajczyk41 merged commit afd2fd5 into main Jan 17, 2025
11 checks passed
@pmikolajczyk41 pmikolajczyk41 deleted the zk-664-sdk-sunset branch January 17, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroist kroist kroist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmikolajczyk41 @kroist