Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Little code style rework. Also change Log.Info to Log.Debug #3

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Little code style rework. Also change Log.Info to Log.Debug #3

wants to merge 14 commits into from

Conversation

fakeman2332
Copy link
Contributor

@fakeman2332 fakeman2332 commented May 16, 2023 •
edited
Loading

  • Code style rework
  • Removed Log.Info spam
  • Moved events to another file
  • Moved to EXILED 💢

@SrLicht
Copy link
Contributor

SrLicht commented Jun 17, 2023

Why are you moving the library to be only compatible with Exiled ?

@xNexusACS
Copy link

Why are you moving the library to be only compatible with Exiled ?

bcs NwAPI sucks

@SrLicht
Copy link
Contributor

SrLicht commented Jul 10, 2023

Why are you moving the library to be only compatible with Exiled ?

bcs NwAPI sucks

And that is a valid reason?

@xNexusACS
Copy link

Why are you moving the library to be only compatible with Exiled ?

bcs NwAPI sucks

And that is a valid reason?

Yes :trollface:

@SrLicht
Copy link
Contributor

SrLicht commented Jul 10, 2023

Que pelotudo de tu parte.

ced777ric
ced777ric requested changes Sep 24, 2023
View reviewed changes
Copy link
Member

@ced777ric ced777ric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no reason to add exiled as dependency, the goal of this api is to be framework independant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ced777ric ced777ric ced777ric requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fakeman2332 @SrLicht @xNexusACS @ced777ric