Merge pull request #10907 from Ostap-Zherebetskyi/fix/preprint_filters

[ENG-6852] Optimize `latest_only` filter for `Preprint`

api/base/filters.py

@@ -610,7 +610,7 @@ def preprints_queryset(self, base_queryset, auth_user, allow_contribs=True, publ
             public_only=public_only,
         )
         if latest_only:
-            preprints = preprints.filter(pk__in=[obj.pk for obj in preprints if obj.is_latest_version])
+            preprints = preprints.filter(guids__isnull=False)
         return preprints
 
 

api/collections/views.py

@@ -80,7 +80,7 @@ def collection_preprints(self, collection, user, latest_only=False):
             user=user,
         )
         if latest_only:
-            preprints = preprints.filter(pk__in=[obj.pk for obj in preprints if obj.is_latest_version])
+            preprints = preprints.filter(guids__isnull=False)
         return preprints
 
     def get_collection_submission(self, check_object_permissions=True):

api_tests/nodes/views/test_node_preprints.py

@@ -154,7 +154,7 @@ def test_unpublished_visible_to_admins(
             preprint_unpublished,
             preprint_published, url):
         res = app.get(url, auth=user_admin_contrib.auth)
-        assert len(res.json['data']) == 1
+        assert len(res.json['data']) == 2
         assert preprint_published._id in [d['id'] for d in res.json['data']]
 
     def test_unpublished_invisible_to_write_contribs(

api_tests/preprints/views/test_preprint_list_mixin.py

@@ -208,7 +208,8 @@ def test_filter_published_false_admin(
         res = app.get(
             f'{url}filter[is_published]=false',
             auth=user_admin_contrib.auth)
-        assert len(res.json['data']) == 0
+        assert len(res.json['data']) == 1
+        assert preprint_unpublished._id in [d['id'] for d in res.json['data']]
 
 
 @pytest.mark.django_db

osf/models/preprint.py

@@ -663,9 +663,7 @@ def csl(self):  # formats node information into CSL format for citation parsing
 
     @property
     def is_latest_version(self):
-        if not self.date_published:
-            return False
-        return self.versioned_guids.first().guid.referent.version == self.version
+        return self.guids.exists()
 
     def get_preprint_versions(self):
         guids = self.versioned_guids.first().guid.versions.all()