Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6670] Make the requested permissions show up as defaults #10891

Conversation

bodintsov
Copy link
Contributor

Purpose

Make the requested permissions show up as defaults in the Request Access List

Changes

TBD

QA Notes

TBD

Documentation

TBD

Side Effects

TBD

Ticket

https://openscience.atlassian.net/browse/ENG-6670

@bodintsov bodintsov marked this pull request as ready for review January 6, 2025 15:58
@bodintsov bodintsov changed the title Make the requested permissions show up as defaults [ENG-6670] Make the requested permissions show up as defaults Jan 6, 2025
@bodintsov bodintsov force-pushed the feature/changed_to_legacy_contributor_page branch from 90d78e7 to 170a457 Compare January 7, 2025 09:49
Copy link
Contributor

@Johnetordoff Johnetordoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep looks good, tested it locally, thanks for digging through all that old mako stuff. 💯

@Johnetordoff
Copy link
Contributor

@bodintsov It looks like you still have one failing test, update with the fix, then if that works assign it to BrianG and he'll merge it.

@bodintsov bodintsov force-pushed the feature/changed_to_legacy_contributor_page branch from 170a457 to 06e7198 Compare January 8, 2025 17:38
@brianjgeiger brianjgeiger merged commit d5138e0 into CenterForOpenScience:feature/institutional_access Jan 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants