[ENG-6800] Fix My Preprints Page #10893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
requested changes
Jan 7, 2025
There was a problem hiding this comment.
I took a further look into this. I think the preprint list by default should provide all the preprints (including versions) since this is how ember-osf-web and ember-osf-reviews relies on.
The fix should be in the place where the my projects page makes the API call. This is a legacy page so it is in this osf.io repo, you can find it by navigating from the website routes.py.
In addition, I think we need to add a filter/param for the list API to receive latest-only preprints.
cslzchen
approved these changes
Jan 7, 2025
|
In addition, will cherry pick and merge this along with #10892 |
|
Merged in 7b16120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update preprints filtering for User preprints endpoint
Changes
Return only latest preprints
QA Notes
N/A
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-6800