-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to combine multiple tilesets #33
Conversation
The 3D Tiles Validator is picking up a small error:
|
@lilleyse I've updated the fix in the new commit and update tests to check it as well |
@lilleyse I just realize I have an unused function |
Overall, the way you've structured the tileset files makes a lot of sense. During testing I did have a few observations that I think could improve this PR.
|
I've created issues for the remaining items:
|
53ed031
to
70c21d7
Compare
Thanks for opening the issues @baothientran. I verified the fixes for everything that was checked off. I also ran the converter and loaded the tilesets in CesiumJS to confirm that nothing strange happened. I briefly looked at the code, didn't have any comments. |
Fixes #19
Add new option to combine multiple tilesets into one.
For example: To combine Elevation with component selectors 1_1 and GSModels with component selectors 2_1 into one, we can do like this:
You can repeat that option multiple times to group different local tilesets into different global tilesets. For example: To group Elevation and GSModels into one tileset and group all GTModels in different tileset, we can do:
With or without the option, the converter still groups each dataset from different GeoCells into a different global tileset for each dataset:
For example, if CDB has two GeoCells with coordinates (N32, W118) and (N32, W119), and each GeoCell has elevation and GSModels dataset, the tiler will combine all the elevation of all GeoCell into one global tileset for Elevation. Same with GSModels. Below is the new organization for global tilesets: