-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 3D Tiles Next extensions #443
Conversation
ef78f63
to
2190421
Compare
Closing for now because the schema directory structure changed and we need a way to do search paths to find schemas that are not in the same tree |
Re-opened and ready for review. Updates just the 3D Tiles and glTF extensions. 3D Tiles 1.1 support will be a follow up PR. |
After merging #465, there are a lot of conflicts in this PR. That isn't surprising, and I intended to just fix it. But the problem is that this branch and that branch generate the glTF classes from different branches of the glTF repo, and apparently their common ancestor is over 5 months old and each have over 150 diverging commits! Scanning the commits, I'm pretty sure this isn't actually true, but instead is a symptom of rebasing. Please don't rebase! Have I mentioned that before? Rebasing publicly-visible branches is pure evil. This is one big reason why. Anyway, I'm probably going to need some help merging these two glTF branches before I can merge this PR. |
The glTF branches should be sorted out now. I merged CesiumGS/glTF#47 and KhronosGroup/glTF#2088 into the I'm definitely guilty of rebasing |
Thanks @IanLilleyT and @lilleyse! |
The whole PR is autogenerated code except for files in the
tools
folder. There I made a few changes:glTF.json
and3dTiles.json
now use updated schemas for 3D Tiles 1.1. I also rearranged the items by extension, by alphabetical order.definitions.schema.json#/definitions/numericValue
. Currently this doesn't affect any of our schemas because the ones that do use the#
end up having many possible types so it defaults toJsonValue
regardless.