-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ModelExperimental
files that don't conflict with Model
#10494
Conversation
Thanks for the pull request @j9liu!
Reviewers, don't forget to make sure that:
|
269dfd2
to
d9bc66e
Compare
@ptrgags could you review when you get the chance? |
Found a bug while I was testing (though it's happening on In the 3D Tiles Next CDB Yemen Sandcastle:
This is the stack trace:
|
Possibly related to CesiumGS/cdb-to-3dtiles#69?
|
Remove glTF 1.0 techniques from Photogrammetry Classification tileset
The renaming looks good, and I searched through the code to make sure nothing was missing. Thanks @j9liu! |
This PR renames several
ModelExperimental
files that don't haveModel
counterparts:ModelExperimental3DTileContent
ModelExperimentalAnimationChannel
ModelExperimentalArticulation
ModelExperimentalArticulationStage
ModelExperimentalDrawCommand
ModelExperimentalRuntimeNode
ModelExperimentalRuntimePrimitive
ModelExperimentalSceneGraph
ModelExperimentalSkin
ModelExperimentalStatistics
ModelExperimentalType
For all of these files, the "Experimental" part of the file / class name has been removed.