Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading tipsets past the range #5225

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Feb 4, 2025

Summary of changes

Changes introduced in this pull request:

  • Fix range tipset lookups that were not taking null rounds into account.
forest-tool api compare --lotus /ip4/127.0.0.1/tcp/1234/http --forest /ip4/127.0.0.1/tcp/2345/http forest_snapshot_calibnet_2025-01-30_height_2364216.forest.car.zst --filter EthGetLogs -n 900
| RPC Method                 | Forest | Lotus |
|----------------------------|--------|-------|
| Filecoin.EthGetLogs (1800) | Valid  | Valid |

Reference issue to close (if applicable)

Closes #5213

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review February 4, 2025 14:16
@elmattic elmattic requested a review from a team as a code owner February 4, 2025 14:16
@elmattic elmattic requested review from lemmih and sudo-shashank and removed request for a team February 4, 2025 14:16
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rock-solid

@elmattic elmattic added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 34d4f27 Feb 4, 2025
48 checks passed
@elmattic elmattic deleted the elmattic/fix-eth-get-logs branch February 4, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Filecoin.EthGetLogs
3 participants