Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds PUDUCHERRY to village_database #53

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

kumarguddu609
Copy link
Contributor

@kumarguddu609 kumarguddu609 commented Feb 1, 2024

What does this PR do?

This PR adds PUDUCHERRY state and its DISTRICTS to village boundary database.
Closes #50

@kumarguddu609
Copy link
Contributor Author

Hey @dhruv-1001 please do checks. if any changes required let me know

@kumarguddu609 kumarguddu609 changed the title adds puducherry to village_database Adds PUDUCHERRY to village_database Feb 1, 2024
@kumarguddu609
Copy link
Contributor Author

Hey @dhruv-1001 Made the changes here and pushed as instructed in this PR

@dhruv-1001
Copy link
Collaborator

LGTM. Please squash your commits. Let's not have more than 1 commit on this.

@dhruv-1001
Copy link
Collaborator

What does this PR do?

This PR adds PUDUCHERRY state and its DISTRICTS to village boundary database. Fixes #28 Closes #50

Also please remove Fixes #28. We don't want to close the tracker issue yet.

@kumarguddu609
Copy link
Contributor Author

What does this PR do?

This PR adds PUDUCHERRY state and its DISTRICTS to village boundary database. Fixes #28 Closes #50

Also please remove Fixes #28. We don't want to close the tracker issue yet.

Okay Should I also remove Fixes from other PRs also?

@dhruv-1001
Copy link
Collaborator

Yes. This should only refer the issue you are collecting the data for.

@kumarguddu609
Copy link
Contributor Author

kumarguddu609 commented Feb 3, 2024

Yes. This should only refer the issue you are collecting the data for.

Okay Got that.

tracks /geojson-data/indian_village_boundaries.zip/puducherry
@kumarguddu609
Copy link
Contributor Author

Hey @dhruv-1001 Squashed and rebase to commit one. Do check and merge if no changes is required.

@dhruv-1001
Copy link
Collaborator

dhruv-1001 commented Feb 6, 2024

Also can you comment on the linked issue? It's weird, i'm not able to assign issue to anyone unless they comments on the issue itself.

@kumarguddu609
Copy link
Contributor Author

Hey @dhruv-1001 I have remove the merge conflicts. Can you do checks and if all good merge it.

@dhruv-1001 dhruv-1001 merged commit 439c03e into ChakshuGautam:master Feb 7, 2024
2 checks passed
35C4n0r pushed a commit that referenced this pull request Jun 5, 2024
Adds PUDUCHERRY to village_database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Village Data Collection - PUDUCHERRY
2 participants