Merge pull request #979 from Choices-js/npm-audit-fix

Switch to dart-sass, fix npm audit issues, add stylelint

.github/workflows/lint.yml

@@ -20,17 +20,13 @@ jobs:
           node-version: 12
 
       - name: Install dependencies
-        run: npm install --no-optional --no-audit --ignore-scripts
+        run: npm ci
         env:
           CYPRESS_INSTALL_BINARY: 0
           HUSKY_SKIP_INSTALL: true
 
       - name: run eslint
-        run: |
-          CHANGED_TS=$(git --no-pager diff --name-only ..origin/master | grep '^src\/scripts\/.*\.ts$' | xargs ls -d 2>/dev/null | paste -sd " " -)
-          if [[ -z $(sed -e 's/[[:space:]]*$//' <<<${CHANGED_TS}) ]]; then CHANGED_TS="src/scripts"; fi
-          echo $CHANGED_TS
-          node node_modules/eslint/bin/eslint.js $CHANGED_TS
+        run: npm run lint:js
 
       ## Can't use same eslint config for TypeScript and JavaScript
       ## TypeScript rules cause rule definition not found errors
@@ -39,3 +35,6 @@ jobs:
       #   run: |
       #     npm run js:build
       #     npx eslint --no-ignore ./public/assets/scripts/*.js
+
+      - name: run stylelint
+        run: npm run lint:scss

.stylelintrc.json

@@ -0,0 +1,6 @@
+{
+  "extends": "stylelint-config-standard-scss",
+  "rules": {
+    "declaration-block-no-redundant-longhand-properties": null
+  }
+}

.vscode/settings.json

@@ -62,5 +62,11 @@
   ],
   "editor.codeActionsOnSave": {
     "source.fixAll.eslint": true
-  }
+  },
+  "stylelint.validate": [
+    "css",
+    "less",
+    "postcss",
+    "scss"
+  ]
 }