-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KLU feature #6
Conversation
206ef5c
to
23c8ed3
Compare
Thanks for your PR. I builds fine with the system Sundials. I see two issues we need to resolve.
|
For the first point, I meant with the vendor libraries; |
regarding the 2nd point: you're right, I didn't think about the size of the submodule. I'm happy with requiring the user to have a local installation of suitesparse and pointing to it via an environment variable. I think this is a reasonable requirement for an optional feature. I can make this change to the PR if you're also happy with this? |
I pushed a commit enabling the KLU feature (in the |
The |
Thanks. I have released version 0.5. |
Fixes #3. This PR:
klu
featureSuiteSparse
submodule (https://github.com/DrTimothyAldenDavis/SuiteSparse)klu
feature is added, then bindings are added for the sundials KLU linear solver (requires both sundials and suitesparse to be installed)SuiteSparse
submodule) to the sundials library build (requires a BLAS installation to be present)Note: I havn't added the klu feature to the CI yet. If would be good to get some feedback on how this should be tested. Should klu be a default feature, or should this be tested separately? Also, the current CI has an issue that I noticed: #5