Index compaction considerations #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…val from trove hash maps
Trove guarantees <11% deviation wrt. prime capacity selection, so let's shrink accordingly if we keep deleting elements.
kelunik
reviewed
Jun 4, 2024
kelunik
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to compact trove maps on excessive oversize, but check only during add. Probably some legacy trade-off, since delete and add are used in update. This leaves a gap in case we keep removing from a particular dump, but never add or update afterwards, retaining the oversize indefinitely.
This solves the method nesting issue and ensures that on-demand compactions happen post-delete. Also, the tolerated oversize is reduced from 25% to 12%, since Trove guarantees <11% wasted space for large hash tables.