Add support for a starting index when connecting nodes. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the `lab.connect_two_nodes()` connects the next two available indexes. Extend this to allow an index where you can start at, for example, 1. This could allow to skip mgmt interfaces.
Spotted by: Patrick Mosko
tmikuska
approved these changes
Dec 10, 2024
tmikuska
pushed a commit
that referenced
this pull request
Jan 26, 2025
* Add support for a starting index when connecting nodes. By default, the `lab.connect_two_nodes()` connects the next two available indexes. Extend this to allow an index where you can start at, for example, 1. This could allow to skip mgmt interfaces. * Consume the position element. Spotted by: Patrick Mosko --------- Co-authored-by: Joe Clarke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
lab.connect_two_nodes()connects the next twoavailable indexes. Extend this to allow an index where you can start
at, for example, 1. This could allow to skip mgmt interfaces.