Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix convergence wait time #128

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix convergence wait time #128

merged 1 commit into from
Jan 7, 2025

Conversation

tmikuska
Copy link
Collaborator

@tmikuska tmikuska commented Jan 6, 2025

I could restrict that attribute to integer or float only, but it was easier to keep the support for both.

Fixed type annotations for the convergence wait time
@tmikuska tmikuska requested review from rschmied and virlos January 6, 2025 16:54
@tmikuska tmikuska changed the base branch from main to dev January 6, 2025 16:54
@PatrikMosko PatrikMosko self-requested a review January 7, 2025 12:15
@tmikuska tmikuska merged commit 1a2a8a2 into dev Jan 7, 2025
5 checks passed
@tmikuska tmikuska deleted the fix-convergence-wait-time branch January 7, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants