script: distribute yield from treasury to staked locker

[erza-eth]

No description provided.

[erza-eth]

To be honest, I'm not quite sure where this revert comes from:

>>> gov.citadel.gac.paused()
False
>>> gov.citadel.gac.hasRole(gov.citadel.gac.CONTRACT_GOVERNANCE_ROLE(), gov)
True
>>> gov.citadel.staked_citadel_locker.getRewardTokens()
()
>>> gov.citadel.staked_citadel_locker.addReward('0x4e3FBD56CD56c3e72c1403e103b45Db9da5B9D2B', '0x38724146C8dc1Aa49c3395
091cf86B789c37F52c', False)
Transaction sent: 0x21edc0475d3d0b0216cb24447fd4646ec9f7a089a24b300fc416d781de61e938
  Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 3
  IStakedCitadelLocker.addReward confirmed (reverted)   Block: 14877930   Gas used: 24171 (0.20%)

<Transaction '0x21edc0475d3d0b0216cb24447fd4646ec9f7a089a24b300fc416d781de61e938'>

See brownie test tests/citadel/test_distribute.py.

[petrovska-petro]

To be honest, I'm not quite sure where this revert comes from:

>>> gov.citadel.gac.paused()
False
>>> gov.citadel.gac.hasRole(gov.citadel.gac.CONTRACT_GOVERNANCE_ROLE(), gov)
True
>>> gov.citadel.staked_citadel_locker.getRewardTokens()
()
>>> gov.citadel.staked_citadel_locker.addReward('0x4e3FBD56CD56c3e72c1403e103b45Db9da5B9D2B', '0x38724146C8dc1Aa49c3395
091cf86B789c37F52c', False)
Transaction sent: 0x21edc0475d3d0b0216cb24447fd4646ec9f7a089a24b300fc416d781de61e938
  Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 3
  IStakedCitadelLocker.addReward confirmed (reverted)   Block: 14877930   Gas used: 24171 (0.20%)

<Transaction '0x21edc0475d3d0b0216cb24447fd4646ec9f7a089a24b300fc416d781de61e938'>

See brownie test tests/citadel/test_distribute.py.

it seems that in this case the gac have not being initiliased, so on the test file requires also to call the following:

gov.citadel.staked_citadel_locker.__GlobalAccessControlManaged_init(gov.citadel.gac.address)

[erza-eth]

thanks, missed that part. added it to the config of the test, passing now.

[petrovska-petro]

lgtm!

[jalbrekt85]

imo better to use Contract/safe.contract opposed to interface.ERC20 since asset is variable and might cause trouble in the future when trying to access functions outside of erc20 interface

[petrovska-petro]

now that posting was included in the distribute_yield script breaks the test. i will say just relay treasury_vault.citadel.distribute_yield(...) for the test

Suggested change

	def test_distribute(cvx):
	def test_distribute(treasury_vault, cvx):
	treasury_vault.citadel.distribute_yield(cvx.address, 123e18)