-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain/2 0 remove deprecations #208
Conversation
@@ -1,5 +1,5 @@ | |||
"""Test serialization and deserialization of gemd objects.""" | |||
import json | |||
import json as json_builtin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? I don't see anything else called json
, and even if there was, I'd suggest aliasing the other thing rather than the built-in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally done b/c I'm having some weird namespace collisions in my IDE, but this didn't fix it. However, there's enough weird use-built-in-for-some-stuff-but-custom-elsewhere in this library that until that gets cleaned up that I think it's important to be clear which is being used. Maybe I'll get it cleaned up next release. Or when we change techs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just that one comment, but it's on a test file and not a big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted in Slack, I'm very opposed to the renaming of the builtin json
import on the basis of clarity, and even more since it's to cater to a specific IDE.
But as I also noted, I don't care enough to argue about it, so I won't block on it.
This PR removes methods that were deprecated, scheduled for removal w/ the 2.0 release.
name
argument fromLinkByUID.from_entity
get_value
andget_enum
fromBaseEnumeration
register_classes
meta-method fromGemdJson
native_uid
argument fromsubstitute_links
from util