Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add addtional synonyms for ratio units #220

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add addtional synonyms for ratio units #220

merged 1 commit into from
Aug 5, 2024

Conversation

kroenlein
Copy link
Collaborator

GEMD Python PR

Description

Follow up for #219 with additional synonyms and definitions.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@kroenlein kroenlein requested a review from anoto-moniz August 2, 2024 18:48
anoto-moniz
anoto-moniz approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@anoto-moniz anoto-moniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kroenlein kroenlein merged commit bb12bd1 into main Aug 5, 2024
16 checks passed
@kroenlein kroenlein deleted the feature/more-unit-synonyms branch August 5, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoto-moniz anoto-moniz anoto-moniz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kroenlein @anoto-moniz