Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the list of supported elements #223

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Update the list of supported elements #223

merged 1 commit into from
Oct 17, 2024

Conversation

kroenlein
Copy link
Collaborator

GEMD Python PR

Description

Adding transuranic elements that are supported by Mithril, as well as formatting the element definition block to be more legible.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

mVenetos97
mVenetos97 approved these changes Oct 17, 2024
View reviewed changes
Copy link

@mVenetos97 mVenetos97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

jspeerless
jspeerless approved these changes Oct 17, 2024
View reviewed changes
Copy link

@jspeerless jspeerless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! LGTM

@kroenlein kroenlein merged commit dfc171e into main Oct 17, 2024
16 checks passed
@kroenlein kroenlein deleted the maintain/add-elements branch October 17, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mVenetos97 mVenetos97 mVenetos97 approved these changes

@jspeerless jspeerless jspeerless approved these changes

@anoto-moniz anoto-moniz Awaiting requested review from anoto-moniz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kroenlein @jspeerless @mVenetos97